gtk/main: Stack ::active calls

We may have the situation of multiple touchpoints in the same
widget, or combinations with other devices. Stack those ::active
states are preserved on widgets on all but the last pointer/touch
going away.

diff --git a/gtk/gtkmain.c b/gtk/gtkmain.c
index 96ff1e69ad485d32e53691016edb04835c7195ad..72941e8620609d9e2fe4443d2e12e3528ac29cd8 100644 (file)
--- a/gtk/gtkmain.c
+++ b/gtk/gtkmain.c
@@ -1362,9 +1362,9 @@ set_widget_active_state (GtkWidget       *target,
   while (w)
     {
       if (release)
-        gtk_widget_unset_state_flags (w, GTK_STATE_FLAG_ACTIVE);
+        gtk_widget_set_active_state (w, FALSE);
       else
-        gtk_widget_set_state_flags (w, GTK_STATE_FLAG_ACTIVE, FALSE);
+        gtk_widget_set_active_state (w, TRUE);
 
       w = _gtk_widget_get_parent (w);
     }

diff --git a/gtk/gtkwidget.c b/gtk/gtkwidget.c
index 861d87a0cfcf0c45a771450c2ae2f63ba3e34282..b71ae1a822eb6b2fdd1a90e45f5a0795c922579d 100644 (file)
--- a/gtk/gtkwidget.c
+++ b/gtk/gtkwidget.c
@@ -12663,3 +12663,29 @@ gtk_widget_class_get_accessible_role (GtkWidgetClass *widget_class)
   priv = widget_class->priv;
   return priv->accessible_role;
 }
+
+void
+gtk_widget_set_active_state (GtkWidget *widget,
+                             gboolean   active)
+{
+  GtkWidgetPrivate *priv = gtk_widget_get_instance_private (widget);
+
+  if (active)
+    {
+      priv->n_active++;
+      gtk_widget_set_state_flags (widget, GTK_STATE_FLAG_ACTIVE, FALSE);
+    }
+  else
+    {
+      if (priv->n_active == 0)
+        {
+          g_warning ("Broken accounting of active state for widget %p(%s)",
+                     widget, G_OBJECT_TYPE_NAME (widget));
+        }
+      else
+        priv->n_active--;
+
+      if (priv->n_active == 0)
+        gtk_widget_unset_state_flags (widget, GTK_STATE_FLAG_ACTIVE);
+    }
+}

diff --git a/gtk/gtkwidgetprivate.h b/gtk/gtkwidgetprivate.h
index 761a190e1d0da3a3ac6f10228868d4be8550601c..138f0137d955a9672cf51792f03ca65ed2ac1e3a 100644 (file)
--- a/gtk/gtkwidgetprivate.h
+++ b/gtk/gtkwidgetprivate.h
@@ -115,6 +115,8 @@ struct _GtkWidgetPrivate
   guint8 verifying_invariants_count;
 #endif
 
+  guint8 n_active;
+
   int width_request;
   int height_request;
 
@@ -324,6 +326,9 @@ void              gtk_widget_get_surface_allocation         (GtkWidget *widget,
 GtkWidget *       gtk_widget_common_ancestor               (GtkWidget *widget_a,
                                                             GtkWidget *widget_b);
 
+void              gtk_widget_set_active_state              (GtkWidget *widget,
+                                                            gboolean   active);
+
 void              gtk_widget_cancel_event_sequence         (GtkWidget             *widget,
                                                             GtkGesture            *gesture,
                                                             GdkEventSequence      *sequence,